Skip to content

feat: Switch to c++20 and remove resulting compile warnings#3124

Open
jmachowinski wants to merge 1 commit intoros2:rollingfrom
cellumation:cpp20
Open

feat: Switch to c++20 and remove resulting compile warnings#3124
jmachowinski wants to merge 1 commit intoros2:rollingfrom
cellumation:cpp20

Conversation

@jmachowinski
Copy link
Copy Markdown
Collaborator

@jmachowinski jmachowinski commented Apr 9, 2026

Description

Switch to cpp20 from lyrical onwards

Is this user-facing behavior change?

yes

Did you use Generative AI?

no

feat: Switch to c++20 and remove resulting compile warnings
ab64733 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski jmachowinski mentioned this pull request Apr 9, 2026
Open
@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 9, 2026

Pulls: ros2/ament_cmake_ros#62, ros2/rcutils#548, #3124
Gist: https://gist.githubusercontent.com/jmachowinski/1538e0f1074c2a0133830f9b6e76ee32/raw/31a05eaaf436bc349c5bf99faec772cce9b5f581/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18900

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski mentioned this pull request Apr 9, 2026
Open
fujitatomoya
fujitatomoya approved these changes Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 13, 2026

Pulls: #3124, ros2/ament_cmake_ros#62, ros2/rcutils#548
Gist: https://gist.githubusercontent.com/ahcorde/308c095a49dc34449d63c4dc7eac9439/raw/31a05eaaf436bc349c5bf99faec772cce9b5f581/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp ament_cmake_ros_core rmw_test_fixture_implementation rcutils
TEST args: --packages-above rclcpp ament_cmake_ros_core rmw_test_fixture_implementation rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18943

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmachowinski @ahcorde @mjcarroll @fujitatomoya