Implement use of sonar msg#50
Open
tylerlum wants to merge 1 commit intoros-simulation:lunar-develfrom
Open
Conversation
c328d4d to
6dda2df
Compare
6dda2df to
f7c7f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
stage_rospreviously treated sonars and lasers as the same type of device and published their data both with the same laser msg type. They both had fov, min/max range, etc. The difference was that sonars have 1 sample and lasers have many. Allranger(laser and sonar) devices in stage had their data published assensor_msgs/LaserScanmsg type, even if they were sonars, but a desired behaviour would be publishing sonar data assensor_msgs/Rangemsg type.Solution: separate all (rangers) -> (sonars + lasers). Then publish laser data as
sensor_msgs/LaserScanmsg type and sonar data assensor_msgs/Rangemsg type. However, stage currently does not differentiate between sonars or infrared devices, so they are all assumed to be infrared