Publish stall state of the robot#42
Open
piliboss wants to merge 1 commit intoros-simulation:lunar-develfrom
Open
Publish stall state of the robot#42piliboss wants to merge 1 commit intoros-simulation:lunar-develfrom
piliboss wants to merge 1 commit intoros-simulation:lunar-develfrom
Conversation
Member
|
I am working with stage ros and I also need to detect collisions with the obstacles. This feature is exactly what solves my problem. It would be great if it is merged within stage. |
Member
|
Sorry, I accidentally closed this when changing the branch layout of the repository. I've reopened it and updated the target base to be |
|
This PR works for me and would be a nice addition. It would help enable automated tests to use Stage for regression testing. |
|
What do you think about changing the Int8 into "std_msgs::Bool"? |
TixiaoShan
approved these changes
May 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are usually encountering a problem while simulating our robots with stage: we are not able to detect whether a robot has collided with an obstacle (just visually but not programmatically).
In your stageros.cpp we also found a todo note for adding a separate publisher for that purpose.
With this pull request, we would like to add such a publisher to stage_ros.
Currently, a Int8 message is sent with the same rate like the odometry message and it indicates whether the robot is stalled or not. We may change the strategy to just send messages as soon as the robot is stalled actually.
What do you think and would it be possible to push this feature to kinetic?
Thank you for your consideration.