Replace bfl ROS package with rosdep keys#6
Open
sloretz wants to merge 1 commit intoros-planning:masterfrom
Open
Replace bfl ROS package with rosdep keys#6sloretz wants to merge 1 commit intoros-planning:masterfrom
sloretz wants to merge 1 commit intoros-planning:masterfrom
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
ahcorde
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this package using a system install of
liborocos-bfl-devon Debian Buster and Ubuntu Focal and the tests seem to pass. This PR replacesbflwith to-be-added rosdep keys. This PR makes themasterbranch work for ROS Noetic only. If multiple ROS distros on the same branch is desired, then I think the package.xml would need to be upgraded to format 3 and conditional dependencies onROS_DISTROwould need to be used.See also ros/rosdistro#23841 and ros-gbp/bfl-release#12