Improve Boost Python component detection for CMake-based Boost installs #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the CMake logic used to locate Boost.Python in
cv_bridge.Recent Boost versions (e.g. 1.89) built with CMake no longer generate
versioned CMake package config files for Python components such as:
Instead, the only available package config file is the generic component:
This causes the current logic:
to fail even though the library file libboost_python311.* exists.
Cause
CMake-built Boost installs:
libboost_python<pyver>.*Boost::pythonBut does not install:
Boost::python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}boost_python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}-config.cmakeAs a result, CMake cannot resolve the requested versioned component, and the
configuration step fails even though the underlying library file exists.
CMake Side FIx
Use versioned Boost.Python components when available, and automatically fall back to the generic
pythoncomponent when they are not.This makes the CMake logic compatible with both CMake-built and Autotools-built Boost installations.