Skip to content

Fixed warning #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 2 commits into from
Jan 20, 2026
+10 −7
Merged

Fixed warning #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da207a3
Fixed warning
ahcorde Jan 19, 2026
b407baa
Merge remote-tracking branch 'origin/rolling' into ahcorde/rolling/am…
ahcorde Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/my_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,24 +58,27 @@ int main(int argc, char ** argv)
point_cloud_transport::Publisher pub = pct.advertise("pct/point_cloud", 100);

const std::string bagged_cloud_topic = "/point_cloud";
const std::string shared_directory = ament_index_cpp::get_package_share_directory(
"point_cloud_transport_tutorial");
std::string bag_file = shared_directory + "/resources/rosbag2_2023_08_05-16_08_51";
std::filesystem::path shared_directory;
ament_index_cpp::get_package_share_directory(
"point_cloud_transport_tutorial",
shared_directory);
std::filesystem::path bag_file = shared_directory / "resources" /
"rosbag2_2023_08_05-16_08_51";

if (argc > 1) {
bag_file = argv[1];
bag_file = std::filesystem::path(argv[1]);
}

if (!std::filesystem::exists(bag_file)) {
std::cout << "Not able to open file [" << bag_file << "]" << '\n';
std::cout << "Not able to open file [" << bag_file.string() << "]" << '\n';
return -1;
}

std::cout << "Reading [" << bag_file << "] bagfile" << '\n';
std::cout << "Reading [" << bag_file.string() << "] bagfile" << '\n';

// boiler-plate to tell rosbag2 how to read our bag
rosbag2_storage::StorageOptions storage_options;
storage_options.uri = bag_file;
storage_options.uri = bag_file.string();
storage_options.storage_id = "mcap";
rosbag2_cpp::ConverterOptions converter_options;
converter_options.input_serialization_format = "cdr";
Expand Down