Skip to content

Conversation

@azeey
Copy link

@azeey azeey commented Jan 22, 2026

Replaces the manual mkdir, git init, and git pull sequence used for cloning the rosdistro repository with an optimized git clone.

I had brought this up before in #750, but shallow clones weren't the right approach.

Key changes:

This change improves both performance and security during the pull request generation phase of the release process.

I've tested successfully on a couple of releases:

Generated-By: Gemini 2.5 Pro

Replaces the manual `mkdir`, `git init`, and `git pull` sequence used for
cloning the rosdistro repository with an optimized `git clone`.

Key changes:
- Uses `--filter=blob:none` (blobless clone) to drastically reduce the
  download size by omitting historical file contents.
- Ensures that OAuth tokens are not persisted in the local git config.
- Includes a fallback to standard clones for Git versions that do not
  support partial clones (pre-2.20).

This change improves both performance and security during the pull
request generation phase of the release process.

Generated-By: Gemini 2.5 Pro
Signed-off-by: Addisu Z. Taddese <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@7855f00). Learn more about missing BASE report.

Files with missing lines Patch % Lines
bloom/commands/release.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #755   +/-   ##
=========================================
  Coverage          ?   54.46%           
=========================================
  Files             ?       52           
  Lines             ?     6354           
  Branches          ?     1100           
=========================================
  Hits              ?     3461           
  Misses            ?     2558           
  Partials          ?      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants