[ntuple] Support late model extension of column representations#21740
Open
silverweed wants to merge 4 commits intoroot-project:masterfrom
Open
[ntuple] Support late model extension of column representations#21740silverweed wants to merge 4 commits intoroot-project:masterfrom
silverweed wants to merge 4 commits intoroot-project:masterfrom
Conversation
This change makes GenerateColumns feasible to call while a field already has generated some columns, which is useful to support extending column representations during writing (actual column extension is not supported yet at this stage).
silverweed
force-pushed
the
ntuple_ext_colrep2
branch
from
5d30012 to
7d8cec1
Compare
This is for now an internal-only functionality that will be used by the Merger to extend column representations as needed during merging. Note that we already support reading back extended column reprs, but there is currently no way to write them.
silverweed
force-pushed
the
ntuple_ext_colrep2
branch
from
7d8cec1 to
7f40a1b
Compare
Test Results 21 files 21 suites 3d 6h 22m 32s ⏱️ For more details on these failures, see this check. Results for commit 7f40a1b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
adds support for extending a field's column representatives via
RNTupleModelChangeset. Note that this is currently only an internal API.This functionality will be used by the Merger to transparently support merging of fields with different but compatible column representations. No work is needed on the reading side as we already have support for reading multiple column representations.
Checklist: