[tmva][sofie] fix: correct Mod/FMod Func() constant-folding, add regression test#21735
Open
harz05 wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] fix: correct Mod/FMod Func() constant-folding, add regression test#21735harz05 wants to merge 1 commit intoroot-project:masterfrom
harz05 wants to merge 1 commit intoroot-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
In
tmva/sofie/inc/TMVA/ROperator_BasicBinary.hxx, the Func() method for the Mod and FMod traits was callingstd::pow(t1, t2)instead of the correct modulo operation.Func()is used during constant-folding when both inputs to a Mod/FMod node are ONNX Constant nodes, producing completely wrong output silently.Mod::Funcfixed toreturn t1 % t2FMod::Funcfixed toreturn std::fmod(t1, t2);I've also included a regression test
FMod_ConstantFoldingthat exercises exactly this code path.Checklist:
This PR fixes #21734