[tmva][sofie] Add regression test for ReduceMean kFirst axis reduction#21733
Open
harz05 wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] Add regression test for ReduceMean kFirst axis reduction#21733harz05 wants to merge 1 commit intoroot-project:masterfrom
harz05 wants to merge 1 commit intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 2h 43m 41s ⏱️ For more details on these failures, see this check. Results for commit 3db02ca. |
Contributor
Author
|
The failing tests appear to be pre-existing alma8 issues unrelated to this PR, sofie-keras-parser (Conv2D tests) also fails on master. For TMVA_SOFIE_Keras_HiggsModel.py , im not sure if this is related, could you pls review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds a regression test for the kFirst path in ReduceMean (reduction over leading axes) which was broken by a loop variable typo(fixed in #21683).
ReduceMean_kFirst.onnx: a [3,4] input reduced over axis=0TestCustomModelsFromONNX.cxx: new testReduceMean_kFirstverifying mean over axis=0 gives [4, 5, 6, 7]Checklist:
Follow-up to #21683, as requested by @guitargeek in #21729.