Skip to content

[graf2d] Allow to save canvas as gif image without spurious (incorrect) error messages#21727

Merged
dpiparo merged 3 commits intoroot-project:masterfrom
dpiparo:test_gif
Mar 31, 2026
Merged

[graf2d] Allow to save canvas as gif image without spurious (incorrect) error messages#21727
dpiparo merged 3 commits intoroot-project:masterfrom
dpiparo:test_gif

Conversation

@dpiparo
Copy link
Copy Markdown
Member

@dpiparo dpiparo commented Mar 28, 2026

This PR aims to test on all platforms the creation of gif images, to gather info useful to debug #21561

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

Test Results

    22 files      22 suites   3d 3h 35m 12s ⏱️
 3 829 tests  3 826 ✅  1 💤 2 ❌
75 596 runs  75 576 ✅ 18 💤 2 ❌

For more details on these failures, see this check.

Results for commit c3e48e4.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo marked this pull request as ready for review March 29, 2026 20:32
@dpiparo dpiparo requested a review from couet as a code owner March 29, 2026 20:32
@dpiparo dpiparo changed the title [Exploratory PR] [test] Create also simple gif image [graf2d] Allow to save canvas as gif image without spurious (incorrect) error messages Mar 29, 2026
@dpiparo dpiparo self-assigned this Mar 30, 2026
@dpiparo dpiparo added the clean build Ask CI to do non-incremental build on PR label Mar 30, 2026
@dpiparo dpiparo closed this Mar 30, 2026
@dpiparo dpiparo reopened this Mar 30, 2026
dpiparo added 3 commits March 30, 2026 15:41
…ndle

the method does not re-initialise the error code to success before
proceeding. Therefore, in order to detect success, we need to do that
ourselves.

Fixes root-project#21561
@dpiparo dpiparo merged commit 2fdc9a1 into root-project:master Mar 31, 2026
48 of 53 checks passed
@dpiparo dpiparo deleted the test_gif branch March 31, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant