[io] add RRawFile::DiscourageReadAheadImpl()#21715
Merged
jblomer merged 1 commit intoroot-project:masterfrom Apr 1, 2026
Merged
[io] add RRawFile::DiscourageReadAheadImpl()#21715jblomer merged 1 commit intoroot-project:masterfrom
jblomer merged 1 commit intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 9h 16m 24s ⏱️ For more details on these failures, see this check. Results for commit fdb87e8. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
io-fadvise
branch
2 times, most recently
from
3ada327 to
87eaa89
Compare
silverweed
approved these changes
Mar 30, 2026
Contributor
silverweed
left a comment
silverweed
left a comment
There was a problem hiding this comment.
lgtm, a couple of minor things
Together with buffering, also advise the OS on read-ahead. Only implemented in the UNIX raw file (Linux only), translated to posix_fadvise().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with buffering, also advise the OS on read-ahead. Only implemented in the UNIX raw file, translated to posix_fadvise().
A test on the RNTuple standard benchmarks confirms small to significant improvements with input data coming from HDD and Ceph-FS.