[hist] Implement RHist{Engine,}::Slice()#21692
Open
hahnjo wants to merge 2 commits intoroot-project:masterfrom
Open
[hist] Implement RHist{Engine,}::Slice()#21692hahnjo wants to merge 2 commits intoroot-project:masterfrom
RHist{Engine,}::Slice()#21692hahnjo wants to merge 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 11h 54m 31s ⏱️ For more details on these failures, see this check. Results for commit 437bba2. ♻️ This comment has been updated with latest results. |
hageboeck
approved these changes
Mar 27, 2026
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM, except for small things in the doxygen strings.
It puts together RSliceSpec, axis slicing, and RSliceBinIndexMapper to transform the bin contents and return the sliced histogram.
Taint the global histogram statistics if dropping bin contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It puts together
RSliceSpec, axis slicing, andRSliceBinIndexMapperto transform the bin contents and return the sliced histogram.