[core] Make TDirectory::Append tolerant to identical objects. #20888
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2026
dpiparo
reviewed
Jan 14, 2026
dpiparo
approved these changes
Jan 14, 2026
pcanal
reviewed
Jan 14, 2026
pcanal
reviewed
Jan 14, 2026
|
|
||
| if (replace && obj->GetName() && obj->GetName()[0]) { | ||
| TObject *old; | ||
| while (nullptr != (old = GetList()->FindObject(obj->GetName()))) { |
Member
There was a problem hiding this comment.
The while loop implies that the list could contains multiple times the same names when this is called. In this case the net result was to remove all duplicates and add only the one passed.
With the new code it seems that if the list contains multiple time the same name and already contains the item being passed we can have:
- before this PR: list contains only the argument
- after this PR: list contains the argument and possibly many duplicates.
Member
Author
There was a problem hiding this comment.
Thanks, this should be addressed now!
Test Results 23 files 23 suites 3d 18h 29m 37s ⏱️ Results for commit 359e187. |
hageboeck
force-pushed
the
root7-ownership-1
branch
from
359e187 to
aa1d14c
Compare
When calling TDirectory::Append(obj, replace=true), and obj is already in the directory, don't issue a warning. Proceed to clear the list of any duplicates, issuing a warning for each. This will enable workflows such as: auto h = new TH1D(...); directory->Append(h, true); After this change, the above lines work both with implicit object ownership off and on.
hageboeck
force-pushed
the
root7-ownership-1
branch
from
aa1d14c to
0728d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling TDirectory::Append(obj, replace=true), and obj is already in the directory, return without doing anything.
If obj has the same name as an existing object, but is physically different, the usual warning is raised.
This will enable workflows such as:
After this change, the above lines work both with and without auto registration to gDirectory. This is needed to prepare ROOT for working without auto registration.