feat: update the key management scheme to be compatible with recent Debian key management #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebian key management apt-key is deprecated. One is now supposed to save the keys separately in /etc/apt/keyrings and refer to them with the signed-by attribute. This commit updates the existing scheme to allow for named keys, that is the 'keys' entries in osrepos can have a 'name' entry, and the 'repo' entries should have a 'key' entry with the name of that key If a key has a name, it is saved in /etc/apt/keyrings instead of being passed to apt-key. If a repo has a 'key' entry, it gets the corresponding signed-by attribute.
doudou
force-pushed
the
new_apt_key_management
branch
from
1ad26d8 to
c35fe5c
Compare
Aruba 2.2 seems to have a weird bug related to accessing `stdin`. Stick to 2.1 on ruby < 3 and move to 2.3 on ruby > 3
Contributor
|
Cool! Tests are failing though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt-key is deprecated. One is now supposed to save the keys separately in
/etc/apt/keyrings and refer to them with the signed-by attribute.
This commit updates the existing scheme to allow for named keys, that is
the 'keys' entries in osrepos can have a 'name' entry, and the 'repo' entries
should have a 'key' entry with the name of that key
If a key has a name, it is saved in /etc/apt/keyrings instead of being passed
to apt-key. If a repo has a 'key' entry, it gets the corresponding signed-by
attribute.