Fix type alias lookup for platform requirements #8948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
At least the rank part of this should also be fixed by #8945 |
For-clause type aliases (e.g., `[Model : model] for main`) weren't being added to the platform-to-app ident translation map, causing false "MISSING PLATFORM REQUIRED TYPE" errors during `roc check`. This change adds the alias name (e.g., "Model") and rigid name (e.g., "model") mappings in both compile_build.zig and main.zig, ensuring the type checker can properly resolve platform requirement types. Note: The original issue #8947 also had a rank mismatch panic, but that was fixed separately by #8945. This PR now only contains the type alias lookup fix. Fixes #8947 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
lukewilliamboswell
force-pushed
the
fix-issue-8947
branch
from
dfe7138 to
406860a
Compare
lukewilliamboswell
changed the title
jaredramirez
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8947 by adding for-clause type alias mappings to the platform-to-app ident translation map.
For-clause type aliases (e.g.,
[Model : model] for main) weren't being added to the translation map, causing false "MISSING PLATFORM REQUIRED TYPE" errors duringroc check.Note: The original issue also had a rank mismatch panic ("trying unifyWith unexpected ranks 1 & 0"), but that was fixed separately by #8945. This PR now only contains the type alias lookup fix.
Changes
Fixed type alias lookup in
src/compile/compile_build.zigandsrc/cli/main.zigAdded for-clause type alias mappings to the platform-to-app ident translation map. This ensures both the alias name (e.g., "Model") and rigid name (e.g., "model") are properly mapped when checking platform requirements.
Added regression test in
src/cli/test/roc_subcommands.zigTest verifies that
roc check test/int/app.rocdoes not panic.Test Plan
roc check test/int/app.roc- Reports "No errors found" (previously showed false errors)roc test/int/app.roc- Works correctly, reports "ALL TESTS PASSED"🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 [email protected]