fix: allow internal whitespace in severity threshold marker for Gemini agent#640
Open
graycoldknight wants to merge 1 commit intoroborev-dev:mainfrom
Open
Conversation
Fixes an issue where the Gemini model agent sometimes outputs the `SEVERITY_THRESHOLD_MET` marker with internal newlines (e.g., `SEVERITY_THRESHOLD\n_MET`), causing the `IsMarkerOnlyOutput` check to fail and incorrectly flag the review as a failure. By stripping internal whitespace before the final string comparison, this parser quirk is resolved while still rejecting output that contains other prose.
roborev: Combined Review (
|
Collaborator
|
We should probably make this conditional on the gemini models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the Gemini model agent sometimes outputs the
SEVERITY_THRESHOLD_METmarker with internal newlines (e.g.,SEVERITY_THRESHOLD\n_MET), causing theIsMarkerOnlyOutputcheck to fail and incorrectly flag the review as a failure.Evidence
We tested this by feeding
SEVERITY_THRESHOLD\n_METandSEVERITY_THRESHOLD\n\n_METtoIsMarkerOnlyOutput. Previously it failed, but with the stripping of internal whitespace (\n,\r,\t,internal/config/config_test.go.