fix: emit empty strings through valueStream instead of throwing missingData #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngData Closes rive-app#416 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <[email protected]> Co-Authored-By: Happy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #416 —
valueStreamthrowsmissingDatawhen a string property is set to"", permanently killing the listener.The ObjC++ bridge in
RiveViewModelInstanceData.mmwas filtering out empty strings withif (!data.stringValue.empty()), leaving_stringValueasnil. The Swift layer then interpretednilas missing data and terminated the stream.The fix removes the
empty()guard forstring/enumTypetypes so empty strings are correctly bridged as@"".Test plan
test_value_withEmptyStringProperty_returnsEmptyString— one-shot value request returns""test_valueStream_withEmptyStringProperty_yieldsEmptyString— stream yields""without throwing