-
Notifications
You must be signed in to change notification settings - Fork 21
Unified framework for volumetrics #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylegulshen
wants to merge
60
commits into
master
Choose a base branch
from
unified_vol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-benchmarking into wholeness-n-implicate-order
…st-benchmarking into wholeness-n-implicate-order
…st-benchmarking into wholeness-n-implicate-order
Contributor
Author
|
It would be great to get a review of this. I know it's a bit long, but much of the code is just defining various |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of the work that @joshcombes started in previous branches, but differs somewhat in approach. The
CircuitTemplateis an attempt to accommodate some of the variety of circuit families of interest.The desire is to randomly sample many circuits with various widths and depths from some family. The approach of
CircuitTemplateis to (hopefully) enable easy specification of circuit families by composition of basic building blocks. After specifying a family we can generate samples of a given width and depth at will.The basic building blocks themselves can be quite diverse and require different resources and inputs. This adds to the complexity of
CircuitTemplatewhich must use these disparate blocks in concert.