[WIP] Added a simple generator for gate-dependent depolarizing noise. #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohaibalam
reviewed
Jul 9, 2019
| return pauli_kraus_map(probabilities) | ||
|
|
||
|
|
||
| def generate_depolarizing_noise_model(qc: QuantumComputer, show_progress_bar: bool = True, |
Contributor
There was a problem hiding this comment.
Is it reasonably sufficient (and/or fairly standard) to only consider a depolarizing noise model? What about things like cross-talk?
msohaibalam
reviewed
Jul 9, 2019
| gates = gates_in_isa(qc.get_isa()) | ||
| kraus_maps = [] | ||
| for g in tqdm(gates, disable=not show_progress_bar): | ||
| if g.name in ('RZ', 'I'): |
Contributor
There was a problem hiding this comment.
Could these be subject to coherent errors?
msohaibalam
reviewed
Jul 9, 2019
| combine_kraus_maps(noise_kraus, [matrix]), fidelity)) | ||
| kraus_maps.append(km) | ||
|
|
||
| return NoiseModel(kraus_maps, single_qubit_conf_matrices) |
Contributor
There was a problem hiding this comment.
I think it would also be worth adding a helper function that would convert the NoiseModel here to a Program or a set of pragma instructions that a user could append to their program, in order for the latter to feel the effects of the noise model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation, example notebook, and testing should be added before merging. I haven't yet tested for correctness.