Skip to content

Code optimization and fix share link from Recordings and roomRecordings. #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CherifAmine wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Code optimization and fix share link from Recordings and roomRecordings. #867

CherifAmine wants to merge 2 commits into from

Conversation

@CherifAmine
Copy link
Contributor

@CherifAmine CherifAmine commented Aug 7, 2023 •
edited
Loading

Description

  • Fix display style recordings Card from roomRecordings.
  • Fix share social media from Recordings and rooms Recordings.
  • Fix Replay button.
  • Code optimization.

Changes Made

Create a new component for Modal Social Links to avoid rewriting the same code.

Closes Issue(s)

Related Issue(s)

#774

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

image image image image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
15.1% 15.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@CherifAmine CherifAmine mentioned this pull request Aug 7, 2023
Closed
8 tasks
@marwa-benhassine marwa-benhassine added the quality control: changes requested Approved (for when the QA testing team approves the changes) label Aug 7, 2023
@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Aug 7, 2023

Publish/unpublish the recording is not working

@CherifAmine CherifAmine added component: recordings Changes related to recording and playback functionalities. component: rooms Changes related to virtual meeting rooms or spaces. labels Aug 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CherifAmine CherifAmine

@marwa-benhassine marwa-benhassine

@fatenrakrouki123 fatenrakrouki123

Labels

component: recordings Changes related to recording and playback functionalities. component: rooms Changes related to virtual meeting rooms or spaces. quality control: changes requested Approved (for when the QA testing team approves the changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CherifAmine @marwa-benhassine @fatenrakrouki123