-
Notifications
You must be signed in to change notification settings - Fork 74
COO-1515: cluster/component healh backend & resources update #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tremes The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jgbernalp please take a look 🙏 |
|
@tremes: This pull request references COO-1515 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
826ed7e to
b637a59
Compare
b637a59 to
7be2ec7
Compare
|
LGTM |
7be2ec7 to
45d2a84
Compare
simonpasquier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial understanding was that the incidents and clusterHealthAnalyzer were equivalent hence I'm not sure to get why we deploy additional resources when clusterHealthAnalyzer is enabled.
|
Not directly to this PR but it looks like we don't have any end-to-end tests for the health analyzer (even something as simple as adding the plugin with the feature being enabled and testing that the resource is successfully reconciled)? |
@simonpasquier They were the same, but we want to enable this new feature (cluster/component health) in the cluster-health-analyzer and therefore these updates.
👍 I will create a task for this. |
I suppose that it's more about me not understanding the scope of the work. Let's chat tomorrow morning. |
45d2a84 to
f735981
Compare
f735981 to
ce95d31
Compare
This enables new feature "component health" evaluation in the cluster-health-analyzer. The feature is tracked in OBSDA-1293. The main additions here are: