Feature/auto discover good commit by coiby · Pull Request #17 · rhkdump/kernel-auto-bisect

coiby · 2026-04-06T06:34:13Z

No description provided.

Github Action will run basic tests including format-check, static-analysis and unit-tests. And testing farm will run integration tests.

Instead of comparing hardcoded /boot paths, use ORIGINAL_KERNEL_RELEASE to verify if the kernel being removed is the original one. This allows proper identification even if kernels are installed to unusual paths like /boot/boot/ (e.g. when using guestmount, chroot and dnf install).

If the program aborts after the running test kernel get removed, the program can fail to build the kernel next time because "make localmodconfig" will fail. So always reboot to the original kernel. And add a trap so when the program aborts it will be rebooted to the original kernel.

When GOOD_COMMIT is omitted, the tool will use exponential search (doubling steps backwards through history) to find a good commit automatically, in both git source and RPM modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Six tasks covering: _rpm_releases array, find_good_commit() function, tests for all modes, initialize() integration, verify skip, and docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Populates an ordered array of kernel releases during RPM list processing, needed for index-based traversal in auto-discovery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Walks backward through history with doubling steps to auto-discover a good commit when GOOD_COMMIT is not specified. Supports both git and RPM modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Add test for git mode when no good commit is found (aborts with error) - Add tests for RPM mode: success case and BAD_COMMIT validation - Fix exponential search to test index 0/root commit as final fallback when the exponential steps skip over the earliest commit - Add *.swp to .gitignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

When GOOD_COMMIT is not specified, initialize() now only validates BAD_COMMIT in RPM mode and leaves GOOD_REF empty. The auto-discovery happens later in verify_intial_commits(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Reorders verify_intial_commits() to check the bad commit first. If it's not actually bad, there's no point searching for a good commit. When GOOD_REF is empty, calls find_good_commit() after verifying bad. When GOOD_REF is set, verifies it normally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Updated bisect.conf to clarify that GOOD_COMMIT is optional and describe the auto-discovery behavior using exponential search backward through history. Updated README.md to mark GOOD_COMMIT as optional in both Git Mode and RPM Mode configuration tables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

So the feature that users only need to specify GOOD_COMMIT can be tested.

… without crashkernel When the to-be-tested kernel is already installed but doesn't have the kernel crashkernel set up, the ssh_auto test plan will fail. Because kdump-utils will only set up crashkernel parameter when a kernel is freshly installed. Thus it won't work for already installed kernel. Call "kdumpctl reset-crashkernel --kernel=ALL" unconditionally to address this corner case. Also optimize the code that enables kdump.serive.

github-actions · 2026-04-06T06:34:25Z

🤖 Hi @coiby, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

github-actions

📋 Review Summary

This Pull Request introduces a significant new feature: auto-discovery of the good commit. The implementation is well-designed, robust, and includes comprehensive test coverage for both git and RPM modes, as well as various edge cases. The changes are well-integrated into the existing codebase, and documentation (README, bisect.conf) has been updated to reflect the new optional GOOD_COMMIT parameter.

🔍 General Feedback

The addition of the trap SIGINT in kab.sh is an excellent safety improvement.
The refactoring of do_abort and setup_kdump functions improves maintainability and clarity.
Thorough test coverage for the new feature in spec/find_good_commit_spec.sh is commendable.

github-actions · 2026-04-06T06:35:35Z

.github/workflows/main.yml


      - name: Unit Tests
        run: |
+          dnf install git -yq


🟢 This change is good to ensure git is available for unit tests, especially with the new features relying on git operations. It clarifies the environment setup for the CI/CD pipeline.

github-actions · 2026-04-06T06:35:39Z

handlers/install_handler.sh

 		log "Failed to run 'make localmodconfig, will try $ORIGINAL_KERNEL_CONFIG"
-		# The test kernel may be removed. As a result "make localconfig" won't work
+		# The test kernel may be removed. As a result, "make localmodconfig"
+		# may not work. "make localmodconfig" will need to find a base config


🟢 The updated comment provides much better context on why make localmodconfig might fail and what the fallback mechanism entails. This greatly improves the maintainability and debuggability of the script.

github-actions · 2026-04-06T06:35:42Z

handlers/install_handler.sh

@@ -49,8 +51,8 @@ remove_test_kernel() {
 	if [[ -z "$kernel_to_remove" ]]; then return; fi

 	# Safety check: never remove the original kernel


🟢 This change makes the safety check for remove_test_kernel more robust and direct by comparing the kernel release strings. It's a good improvement to prevent accidental removal of the original kernel.

github-actions · 2026-04-06T06:35:45Z

kab.sh

 #
 # shellcheck source=lib.sh
 source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib.sh"



🟠 Adding a trap for SIGINT to call reboot_to_origin_kernel is an excellent safety enhancement. It ensures that the system returns to a known good state even if the bisection process is interrupted, which is crucial for reliability.

github-actions · 2026-04-06T06:35:49Z

lib.sh

@@ -102,6 +102,7 @@ signal_checkpoint() {
 }

 declare -A release_commit_map


🟢 Declaring _rpm_releases=() here is a good and necessary step for the new RPM mode auto-discovery feature. It ensures the array is properly initialized before use.

github-actions · 2026-04-06T06:36:10Z

lib.sh

@@ -349,22 +429,23 @@ setup_kdump() {
 			fi


🟢 Updating the RPM initialization logic to treat GOOD_COMMIT as optional and only abort if BAD_COMMIT or a provided GOOD_COMMIT is not found, correctly integrates the auto-discovery feature. This ensures flexibility for the user while maintaining necessary checks.

github-actions · 2026-04-06T06:36:14Z

lib.sh

-				do_abort "KERNEL_RPM_LIST file not found."
-			fi
 			# kexec reboot by default inherit /proc/cmdline. So make sure
 			# crashkernel exists in /proc/cmdline


🟠 The integration of find_good_commit into initialize() when GOOD_REF is empty is the core of the new auto-discovery feature. This ensures that a good commit is automatically identified when the user doesn't provide one, streamlining the bisection process.

github-actions · 2026-04-06T06:36:24Z

spec/find_good_commit_spec.sh

@@ -0,0 +1,211 @@
+#!/bin/bash


🟡 The addition of spec/find_good_commit_spec.sh provides excellent test coverage for the new auto-discovery feature. The test cases cover both git and RPM modes, including success scenarios, failure conditions, and edge cases like root commit fallback, demonstrating a thorough approach to testing.

github-actions · 2026-04-06T06:36:28Z

spec/remove_test_kernel_spec.sh

@@ -44,23 +45,19 @@ Describe 'remove_test_kernel'
 	End

 	Describe "safety check"


🟡 The updated and new test cases for remove_test_kernel significantly improve the testing for the safety check. This ensures that the original kernel is not accidentally removed, even under various conditions, which is critical for system stability.

github-actions · 2026-04-06T06:36:31Z

tests/kab_criu/test.sh

@@ -54,7 +54,6 @@ INSTALL_STRATEGY="rpm"
 TEST_STRATEGY="panic"
 REBOOT_STRATEGY=


🟢 Removing the explicit GOOD_COMMIT=$GOOD_COMMIT from the test configurations is correct, as GOOD_COMMIT is now optional and can be auto-discovered. This aligns the tests with the new feature's behavior.

Testing harm reject hardcoded provision method 'virtual.testcloud', Suitable provision method 'virtual.testcloud' disallowed by configuration

coiby and others added 16 commits April 6, 2026 10:37

ci: Use GitHub Action and testing farm to run tests

d33050b

Github Action will run basic tests including format-check, static-analysis and unit-tests. And testing farm will run integration tests.

Add design spec for auto-discovering good commit

c4dc5ec

When GOOD_COMMIT is omitted, the tool will use exponential search (doubling steps backwards through history) to find a good commit automatically, in both git source and RPM modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add .worktrees/ to .gitignore

354b630

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add implementation plan for auto-discover good commit

67d50d1

Six tasks covering: _rpm_releases array, find_good_commit() function, tests for all modes, initialize() integration, verify skip, and docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add _rpm_releases array to generate_git_repo_from_package_list

85abf1a

Populates an ordered array of kernel releases during RPM list processing, needed for index-based traversal in auto-discovery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add find_good_commit() with exponential search

301538d

Walks backward through history with doubling steps to auto-discover a good commit when GOOD_COMMIT is not specified. Supports both git and RPM modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Make GOOD_COMMIT optional in initialize()

26a80d1

When GOOD_COMMIT is not specified, initialize() now only validates BAD_COMMIT in RPM mode and leaves GOOD_REF empty. The auto-discovery happens later in verify_intial_commits(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add test for root commit fallback in find_good_commit

de7420a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

tests: Don't specify GOOD_COMMIT in criu and ssh tests

6f015b8

So the feature that users only need to specify GOOD_COMMIT can be tested.

Update code comment for ssh bisecting

d95ba79

github-actions bot reviewed Apr 6, 2026

View reviewed changes

coiby force-pushed the feature/auto-discover-good-commit branch 2 times, most recently from b018685 to 7fcdea6 Compare April 6, 2026 06:51

Update tests Github Action

7c1a398

coiby force-pushed the feature/auto-discover-good-commit branch from 7fcdea6 to 7c1a398 Compare April 6, 2026 06:59

tests: Allow test plans to be run by testing farm

4b48b3e

Testing harm reject hardcoded provision method 'virtual.testcloud', Suitable provision method 'virtual.testcloud' disallowed by configuration

coiby force-pushed the main branch 4 times, most recently from 75b8caa to 77a9584 Compare April 7, 2026 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/auto discover good commit#17

Feature/auto discover good commit#17
coiby wants to merge 18 commits intomainfrom
feature/auto-discover-good-commit

coiby commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

github-actions bot Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -49,8 +51,8 @@ remove_test_kernel() {
		if [[ -z "$kernel_to_remove" ]]; then return; fi

		# Safety check: never remove the original kernel

		@@ -102,6 +102,7 @@ signal_checkpoint() {
		}

		declare -A release_commit_map

		@@ -44,23 +45,19 @@ Describe 'remove_test_kernel'
		End

		Describe "safety check"

		@@ -54,7 +54,6 @@ INSTALL_STRATEGY="rpm"
		TEST_STRATEGY="panic"
		REBOOT_STRATEGY=

Conversation

coiby commented Apr 6, 2026

Uh oh!

github-actions bot commented Apr 6, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

📋 Review Summary

🔍 General Feedback

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant