Conversation
The raw dump target (using dd to a partition) is being phased out in favor of filesystem-based targets. This patch adds deprecation warnings to the documentation and runtime scripts to alert users that support will be removed in a future release. Resolves: rhkdump#141 Assisted-by: Google Gemini Signed-off-by: Lichen Liu <lichliu@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the deprecation process for raw dump targets within the kdump system. It introduces clear warnings in both user-facing documentation and the core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates the raw dump target by adding warnings to documentation and runtime scripts. The changes are clear and well-implemented. I have one suggestion to improve the runtime deprecation message to make it more actionable for users.
| fi | ||
| ;; | ||
| raw) | ||
| dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target." |
There was a problem hiding this comment.
The deprecation warning is a great addition. To make it more actionable for users, consider mentioning some examples of supported filesystem-based targets. This helps guide them toward a valid configuration without them necessarily needing to consult the documentation for examples.
| dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target." | |
| dwarn "The 'raw' dump target is deprecated and will be removed in a future release. Please migrate to a filesystem-based dump target (e.g., ext4, xfs, nfs, or ssh)." |
There was a problem hiding this comment.
I find the suggestion made by Gemeni better. Can you please use it.
prudo1
left a comment
prudo1
left a comment
There was a problem hiding this comment.
Hi @licliu,
thanks for your PR. All in all it looks good to me. Can you please address the nits mentioned in the comments below.
In addition, I would remove Resolves: #141 from the description. IMHO this PR is only the first step to resolve #141. For #141 to be fully resolved we would need to remove the code for raw targets.
Thanks
Philipp
| # - Will dd /proc/vmcore into <partition>. | ||
| # Use persistent device names for partition devices, | ||
| # such as /dev/vg/<devname>. | ||
| # NOTE: raw dump targets will be deprecated in a future version. |
There was a problem hiding this comment.
Personally I'd remove everything following the dash - and replace it with what Gemeni has suggested. So the entry reads
# raw <partition>
# The 'raw' dump target is deprecated and will be removed in a future
# release. Please migrate to a filesystem-based dump target (e.g., ext4,
# xfs, nfs, or ssh).
In addition I think the example below, aka. the line #raw /dev/vg/lv_kdump, should be removed as well.
| Will dd /proc/vmcore into <partition>. Use persistent device names for | ||
| partition devices, such as /dev/vg/<devname>. | ||
| partition devices, such as /dev/vg/<devname>. Raw dump targets will be | ||
| deprecated in a future version. | ||
| .RE |
There was a problem hiding this comment.
Same like above in gen-kdump-conf.sh
| fi | ||
| ;; | ||
| raw) | ||
| dwarn "Raw targets will be deprecated and removed in the future. Please migrate to a supported dump target." |
There was a problem hiding this comment.
I find the suggestion made by Gemeni better. Can you please use it.
| initrd. Dump target should be persistent device name, such as lvm or device | ||
| mapper canonical name. | ||
|
|
||
| Raw targets will be deprecated in a future version. | ||
|
|
||
| 2) Dedicated file system |
There was a problem hiding this comment.
Just for completion. Ideally we would use the same phrasing like in gen-kdump-conf.sh and the man page. But that would require to adjust the Dedicated file system section as well as it references this section. Personally I think that is too much for the deprecation and should be done when we remove the code. At that point we'll need to make more adjustments to kexec-kdump-howto.txt anyway. So I'm fine with keeping it this way.
|
Thanks @prudo1 for carefully review! I will fix them in next version. |
2 participants
The raw dump target (using dd to a partition) is being phased out in favor of filesystem-based targets. This patch adds deprecation warnings to the documentation and runtime scripts to alert users that support will be removed in a future release.
Due to editor settings, this patch also removes some trailing spaces.
Resolves: #141
Assisted-by: Google Gemini