Skip to content

test/reproducers/2036462/runtest.sh: improved regex to match JDK8#40

Merged
judovana merged 2 commits intorh-openjdk:mainfrom
zzambers:jdk8-regex-fix
Oct 21, 2025
Merged

test/reproducers/2036462/runtest.sh: improved regex to match JDK8#40
judovana merged 2 commits intorh-openjdk:mainfrom
zzambers:jdk8-regex-fix

Conversation

@zzambers
Copy link
Contributor

Regex should match literal dots, otherwise it can lead to false matches. (there can be match in jfr output)

@judovana
Copy link
Collaborator

Thanx. I'm afraid more of my "run.sh" have this bug. ok to go after jdk8 gh actions finishes

@zzambers
Copy link
Contributor Author

Did not came to my mind to check for this in other files. Fixed other ones too. :)

@judovana
Copy link
Collaborator

Oh,, I had jsut realised:

@judovana
Copy link
Collaborator

Oh,, I had jsut realised:

JDK_MAJOR=$( "$JAVA/bin/jshell" "${jshellScript}" 2> /dev/null | grep -v -e "Started recording" -e "copy recording data to file" -e "^$" -e "\[" )

Obviously is not doing a proepr job, when jdk8 detection is needed later, and in addition the flight recoding may spoil the outputs...

@zzambers
Copy link
Contributor Author

Oh,, I had jsut realised:

JDK_MAJOR=$( "$JAVA/bin/jshell" "${jshellScript}" 2> /dev/null | grep -v -e "Started recording" -e "copy recording data to file" -e "^$" -e "\[" )

Obviously is not doing a proepr job, when jdk8 detection is needed later, and in addition the flight recoding may spoil the outputs...

That is more involved check. :) However, I think current fix should hopefully be sufficient.

@zzambers
Copy link
Contributor Author

Hmm, seems I don't have privileges to merge here.

@judovana
Copy link
Collaborator

That is more involved check. :) However, I think current fix should hopefully be sufficient.

Definitley sufficient, all tests shoudl be standalone in addition. I was jut wondering if that grep clean up can be inmproved,, by some -ive [jfr] or simialrly

Hmm, seems I don't have privileges to merge here.

Cool. I canbe useful :D

@judovana judovana merged commit c4f44cf into rh-openjdk:main Oct 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants