This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Modifed addFilters to avoid error when the end_time or start_time are… #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not defined in the filters
ocoletocegid
requested review from
BadChoice,
JordiFL-Revo,
MartiSalaMorral and
kiriamcf-revo
BadChoice
suggested changes
Nov 26, 2024
| $endTime = $timeValues['end_time'] ?? null; | ||
|
|
||
|
|
||
| if ($startTime && $endTime) { |
Contributor
There was a problem hiding this comment.
Aquí hi ha masses ifs/elses, faria 3 coses
- Crear una classe nova que es digui TimeFilter i delegar tot aquest codi cap alla
- Dins d'aquesta classes tenir dos funcions, la del startTime < endTime i l'altra, amb noms, així l'if queda més endreçat
3.Delegar les funcion del setStartTime i setEndTime en aquesta nova classe, així tenim un lloc centralitzat tot el referent al "time"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear: rev-17547