Conversation
| add_definitions(-DLIBRARY_VERSION="${LibraryVersion}") | ||
|
|
||
| COMPILELIB("") | ||
| set(deps detector) |
There was a problem hiding this comment.
I think that is conceptually wrong to add dependencies to any legacy class or library
There was a problem hiding this comment.
Yes, probably we just need the data members and the name of the class being preserved for data being read from previous ROOT files.
|
|
||
| #include "TRestDetectorDriftVolume.h" | ||
|
|
||
| typedef TRestDetectorDriftVolume TRestDriftVolume; |
There was a problem hiding this comment.
This class has been renamed? Not quite understand this class
|
|
||
| #include "TRestDetectorGainMap.h" | ||
|
|
||
| typedef TRestDetectorGainMap TRestGainMap; |
There was a problem hiding this comment.
Same here? The typedef shouldn't be included in TRestDetectorGainMap.h?
|
|
||
| #include "TRestDetectorGas.h" | ||
|
|
||
| typedef TRestDetectorGas TRestGas; |
|
|
||
| //! An event data type that register a vector of TRestHits, | ||
| //! allowing us to save a 3-coordinate position and energy. | ||
| class TRestHitsEvent : public TRestEvent { |
There was a problem hiding this comment.
I think that TRestHitsEvent should inherit from TRestLegacyEvent with some protection added
| ClassDefOverride(TRestLegacyProcess, 0); | ||
| }; | ||
|
|
||
| #define LegacyProcessDef(thisname, newname, n) \ |
There was a problem hiding this comment.
I am not fan of macros and I don't understand the need of a macro here
|
|
||
| //! A process to identify signal and remove baseline noise from a TRestRawSignalEvent. | ||
| class TRestRawZeroSuppresionProcess : public TRestLegacyProcess { | ||
| class TRestRawZeroSuppresionProcess : public TRestEventProcess { |
There was a problem hiding this comment.
TRestRawZeroSuppresionProcess should inherit from TRestLegacyProcess
| #include <TString.h> | ||
| #include <TVector2.h> | ||
|
|
||
| class TRestSignal : public TObject { |
There was a problem hiding this comment.
TRestSignal seems quite obsolete, what is the need of implemented inside legacylib?
| #include "TRestEvent.h" | ||
| #include "TRestSignal.h" | ||
|
|
||
| class TRestSignalEvent : public TRestEvent { |
There was a problem hiding this comment.
Same here TRestSignalEvent looks extremelly old, do we have a real need to keep in legacylib?
Also, I think that any legacy class shouldn't implement any data processing, it is just for compatibility with old root files.
| #include "TRestLegacyProcess.h" | ||
|
|
||
| //! A process to identify signal and remove baseline noise from a TRestRawSignalEvent. | ||
| class TRestSignalZeroSuppresionProcess : public TRestEventProcess { |
There was a problem hiding this comment.
TRestSignalZeroSuppresionProcess looks quite similar to TRestRawZeroSuppresionProcess a typedef cannot be used here?
|
I dont understand, |
3 participants
added v2.2 readout and v2.2 process: TRestSignalZeroSuppresionProcess
use preprocessor to define legacy processes members, instead of inheriting TRestLegacyProcess. This prevents a warning: