Add optional volume parameter to use alias observable name #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that nested volumes are accepted in restG4, the volume names can be really long. To avoid the inconvenience of having very long observable names, we can now tell the volume for the obserfvable in a different parameter and set the observable name as any alias you want. For example, setting
the observable name will be
sensGasLeftVolumeEDep, and it will contain the energy deposited in the volumeshielding/outerGas/vesselassembly/gas/sensitiveGasLeftIt would be nice if the description was updated automatically with the name of the volume used (to keep that information somwhere) but I don't find a easy way to do this. So I think is best to let the user be responsible for that.