Track job milestone timestamps directly in JobHandler #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier for hooks to work with these times, rather than having to track those for every job themselves. Previously you could do this with dynamic properties on the JobHandler class, but that is deprecated in PHP 8.2.
danhunsaker
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for hooks to work with these times, rather than having to track those for every job themselves.
Previously you could do this with dynamic properties on the JobHandler class, but that is deprecated in PHP 8.2.
https://github.com/chrisboulton/php-resque-statsd and https://github.com/move-backend/php-resque-influxdb/ are examples for hooks that would need this.