Draft
Conversation
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
andrea-reale
force-pushed
the
andrea/migrate_benchmarks
branch
2 times, most recently
from
14698b8 to
f6a4806
Compare
andrea-reale
added
the
exclude from changelog
andrea-reale
force-pushed
the
andrea/migrate_benchmarks
branch
9 times, most recently
from
99d7d88 to
b10dcf1
Compare
andrea-reale
force-pushed
the
andrea/migrate_benchmarks
branch
from
2b63b30 to
aff6f48
Compare
Signed-off-by: Andrea Reale <andrea@rerun.io>
* Telemetry setup * Metrics publication Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
This fixes an error in download rerun-cli job ``` https://github.com/rerun-io/rerun/actions/runs/20149204817/job/57838646493?pr=12159 ```
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
Signed-off-by: Andrea Reale <andrea@rerun.io>
andrea-reale
force-pushed
the
andrea/migrate_benchmarks
branch
from
aff6f48 to
548eea9
Compare
Signed-off-by: Andrea Reale <andrea@rerun.io>
abey79
approved these changes
Dec 16, 2025
Comment on lines
+11
to
+16
| logger = logging.getLogger(__name__) | ||
|
|
||
| if TYPE_CHECKING: | ||
| from collections.abc import Iterator | ||
|
|
||
| from rerun.catalog import CatalogClient, DatasetEntry |
Member
There was a problem hiding this comment.
nit
Suggested change
| logger = logging.getLogger(__name__) | |
| if TYPE_CHECKING: | |
| from collections.abc import Iterator | |
| from rerun.catalog import CatalogClient, DatasetEntry | |
| if TYPE_CHECKING: | |
| from collections.abc import Iterator | |
| from rerun.catalog import CatalogClient, DatasetEntry | |
| logger = logging.getLogger(__name__) |
| if: ${{ inputs.PLATFORM == 'linux-arm64' }} | ||
| # Workaround for OpenCV TLS issue, see https://github.com/opencv/opencv/issues/14884#issuecomment-815632861 | ||
| run: cd rerun_py/tests && LD_PRELOAD=/usr/lib/aarch64-linux-gnu/libgomp.so.1 pixi run -e wheel-test-min pytest -c ../pyproject.toml | ||
| run: cd rerun_py/tests && LD_PRELOAD=/usr/lib/aarch64-linux-gnu/libgomp.so.1 pixi run -e wheel-test-min pytest -c ../pyproject.toml -m "not cloud_only" |
Member
There was a problem hiding this comment.
is this needed since it's disabled by default? Also, do we want to force opt-in to slow? (genuine question, not sure it makes sense here)
Comment on lines
+61
to
75
| droid_group = parser.getgroup("droid dataset options") | ||
|
|
||
| droid_group.addoption( | ||
| "--droid-dataset", | ||
| action="store", | ||
| default=None, | ||
| help="URI prefix for test resources (e.g., 's3://bucket/path/' for remote resources). " | ||
| "If not provided, local file:// URIs to the resources directory will be used.", | ||
| default="droid:sample50", | ||
| help="Dataset for Droid benchmarks (options: droid:raw, droid:sample50, etc.)", | ||
| ) | ||
|
|
||
| droid_group.addoption( | ||
| "--droid-preregister-dataset", | ||
| action="store_true", | ||
| default=False, | ||
| help="should the test runner register the droid dataset before running tests", | ||
| ) |
Member
There was a problem hiding this comment.
It would be slightly more readable if the adoption code was colocated with the getoption fixtures. Would it make sense to move that to the other conftest.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We are consodlidating
redap-component-testsintoe2e_redap_tests.What
The first step is moving the droid group into
e2e_redap_tests. This change:pytest-benchmarkscloud_onlyandslow)What next
vecbenchgroup