Adding Recording Context in ViewerContext to keep timeline for different storeIds#11943
Adding Recording Context in ViewerContext to keep timeline for different storeIds#11943kratos2377 wants to merge 3 commits intorerun-io:mainfrom
Conversation
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
|
Thanks for contributing! |
|
I have not looked into this PR, so cannot comment on the actual change. What I can say is that I meant this ticket as a high-level usability need. I think designing what we mean exactly by "state" and "time" is necessary before jumping into implementation. This should be grounded on actual use-cases/examples that would clarify what should/could be synchronised. For example, it stands to reason that keeping the same entity selected (if it exists in both recording) might be relatively straightforward. What time synchronisation should do much less so. Time ranges in recording might corresponds (e.g. frame 100), or not at all (e.g wall clock time). Should we consider delta from first data? Or something else? This needs figuring out at the conceptual level first. |
This is not the final change, this is just an approach i am taking to fix the following Issue: #11792
The approach is to basically keep a recording_context map based on storeId in viewer_context and set current selection if any recording switch happens. Currently testing it in my local but just wanted to get some feedback from you guys.
@abey79 @Wumpf @lucasmerlin