Archetype "transform like" components are no longer handled by re_tf
#11819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/store/re_tf/src/transform_forest.rs
…, making existing tests pass again Also... * makes RotationAxisAngle repr C & pod, allowing fast slice conversion * fix ordering of rotation_axis_angle vs quaternion to be consistent
…works fine with frame based transforms
Wumpf
added
the
exclude from changelog
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Wumpf
commented
Nov 7, 2025
Member
Author
There was a problem hiding this comment.
we expect more points here via InstancePoseTransform. That's an open TODO for later.
Wumpf
commented
Nov 7, 2025
Member
Author
There was a problem hiding this comment.
we expect an extra blue box here via InstancePoseTransform. That's an open TODO for later.
Wumpf
commented
Nov 7, 2025
Member
Author
There was a problem hiding this comment.
we expect an extra blue sphere here via InstancePoseTransform. That's an open TODO for later.
…where/when I broke this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes those components also "entity-local" again, fixing issues with the new frames. Extended existing image comparison tests to demonstrate this.
Makes transform book-keeping a lot more lightweight and removes a bunch of strange hacks & corner cases from
re_tf. Overall this is a big win for maintenance ofre_tf.There's still issues with instance pose transforms here that we need to address later.