Test: deselect on escape #11685
Open
Test: deselect on escape #11685
+95
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
aedm
added
the
exclude from changelog
emilk
approved these changes
Nov 4, 2025
| harness.blueprint_tree().right_click_label("3D view"); | ||
| harness.snapshot_app("deselect_on_escape_6"); | ||
| harness.key_press(egui::Key::Escape); | ||
| harness.snapshot_app("deselect_on_escape_7"); |
Member
There was a problem hiding this comment.
Suggestion" add another snapshot after pressing escape yet again. Whatever is currently selected should become unselected, and the recording itself should become selected (which will be visible in the selection panel).
| harness.snapshot_app("deselect_on_escape_6"); | ||
| harness.key_press(egui::Key::Escape); | ||
| harness.snapshot_app("deselect_on_escape_7"); | ||
| } |
Member
There was a problem hiding this comment.
An alternative approach here would be to replace the screenshot tests with actually checking the current selection Item
| @@ -0,0 +1,71 @@ | |||
| use re_integration_test::HarnessExt as _; | |||
Member
There was a problem hiding this comment.
Suggested change
| use re_integration_test::HarnessExt as _; | |
| //! Test that pressing the Escape key will back out of dialogs etc. | |
| use re_integration_test::HarnessExt as _; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Part of #8948
What
check_deselect_on_escape.pyfrom release checklist