Test adding entities to new view #11594
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
aedm
added
the
exclude from changelog
| harness.click_nth_label("3D", 0); | ||
| harness.snapshot_app("add_entity_to_view_boxes3d_3"); | ||
|
|
||
| harness.right_click_nth_label("/", 2); |
There was a problem hiding this comment.
All this nth_label stuff feels a bit brittle to me.. I imagine it could become really annoying if we change unrelated code somewhere that maybe adds another place where we show the name of the selection and then we'd need to update a lot of random nth_label indexes in the integration tests.
Maybe we could do something like harness.blueprint().click_label("/") via HarnessExt?
I think we could even do this in a way that we can still automatically do harness.run() in the event helpers.
This should also help readability of the tests, as it's more obvious whats being interacted with.
There was a problem hiding this comment.
I absolutely agree. I started with these when there was little hierarchy in our accessibility node tree, but now it should be fixed: #11628
| harness.click_nth_label("Text log", 0); | ||
| harness.snapshot_app("add_entity_to_view_text_log_3"); | ||
|
|
||
| // When adding a text log, to a new view, the origin is set to the entity path |
There was a problem hiding this comment.
Does this mean the Space origin should be text_log?
Maybe you can also add an assert for this?
| @@ -0,0 +1,275 @@ | |||
| use egui::accesskit::Role; | |||
There was a problem hiding this comment.
| use egui::accesskit::Role; | |
| //! This file is all about… | |
| use egui::accesskit::Role; |
| // Adds `count` views to the given container, names them sequentially from an index base. | ||
| fn add_views_to_container( |
Related
Part of #8948
What
check_context_menu_add_entity_to_new_space_view.pyfrom release checklist