Skip to content

Use patched lz4 crate #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use patched lz4 crate #11533

wants to merge 3 commits into from

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 14, 2025 •
edited
Loading

This is a follow up to #11525. It fixes the remaining half of #11516.

We don't want to merge it as is yet. Let's see if we can get the fix merged upstream first, so we don't have to depend on yet another fork:

Checks:

  • rerun with --nb_scans 3000 now works
  • rerun rrd stats with --nb_scans 3000 now works

@teh-cmc teh-cmc added 🪳 bug Something isn't working do-not-merge Do not merge this PR dependencies concerning crates, pip packages etc 🪵 Log & send APIs Affects the user-facing API for all languages exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

Web viewer built successfully.

Result Commit Link Manifest
✅ 502d4ff https://rerun.io/viewer/pr/11533 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the cmc/lz4_flex_upstream_fixes branch from 4e98906 to da45a54 Compare October 14, 2025 13:25
@teh-cmc teh-cmc changed the title use patched lz4 crate Use patched lz4 crate Oct 14, 2025
@teh-cmc teh-cmc linked an issue Oct 14, 2025 that may be closed by this pull request
RRD decoder panics on allocation: capacity overflow #11516
Open
@rerun-io rerun-io deleted a comment from github-actions bot Oct 14, 2025
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 14, 2025

@rerun-bot full-check

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Started a full build: https://github.com/rerun-io/rerun/actions/runs/18501698194

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 27, 2025 •
edited
Loading

Patch has been merged upstream, waiting for a release to be published.

@Wumpf
Copy link
Member

Wumpf commented Nov 4, 2025

converting to draft so this doesn't show up on review queue

@Wumpf Wumpf marked this pull request as draft November 4, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🪳 bug Something isn't working dependencies concerning crates, pip packages etc do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RRD decoder panics on allocation: capacity overflow

3 participants

@teh-cmc @Wumpf