Adding ability to manage tag protections via settings#795
Adding ability to manage tag protections via settings#795ctoestreich wants to merge 2 commits intorepository-settings:masterfrom
Conversation
|
@ctoestreich is attempting to deploy a commit to the Repository Settings Team on Vercel. A member of the Team first needs to authorize it. |
|
apologies for the extremely delayed feedback on this. there are recent updates to the testing strategy for the project that i hope make defining various scenarios. unfortunately, that means that you will need to update your changes to align with the new strategy, but hopefully that will make it easier to define additional scenarios of your implementation more clearly, so that the additional coverage helps protect against future regressions |
travi
left a comment
travi
left a comment
There was a problem hiding this comment.
a couple of tweaks to the shape of the proposed config section. also, could you please also update the configuration docs to include an example of this functionality?
| @@ -0,0 +1,3 @@ | |||
| tag_protection: | |||
There was a problem hiding this comment.
lets simplify this to tags to be more similar to the existing branches, for example
| @@ -0,0 +1,3 @@ | |||
| tag_protection: | |||
| - pattern: "v1" | |||
There was a problem hiding this comment.
i don think including pattern here is helpful since it is the only property. lets simplify to just be the pattern
|
also worth considering: #772 (comment) |
2 participants
This should allow tag protection