feat(types) - extend types #4
Conversation
dist/index.d.ts
Outdated
| @@ -1,16 +1,18 @@ | |||
| import { createHeadlessForm as createHeadlessForm$1, modify as modify$1, CreateHeadlessFormOptions } from '@remoteoss/json-schema-form'; | |||
| import { CreateHeadlessFormOptions, createHeadlessForm as createHeadlessForm$1, ValidationResult as ValidationResult$1, modify as modify$1 } from '@remoteoss/json-schema-form'; | |||
There was a problem hiding this comment.
I saw a dist folder in the repo is this intented?
To publish a new version I guess I need to change the package.json right?
There was a problem hiding this comment.
@gabrielremote the dist shouldn't be here, I'm almost sure. The package.json shouldn't be needed to be change either, as it already exports the types.
There was a problem hiding this comment.
Are you still blocked? I can look into this in detail if you need.
There was a problem hiding this comment.
I think we need the dist until we publish in npm as we're installing the package like "@remoteoss/remote-json-schema-form-kit": "github:remoteoss/remote-json-schema-form-kit#v0.0.1"
There was a problem hiding this comment.
Ahh! I didn't review the initial MR at all so I don't know the caveats/deployment. It seems we don't have docs yet either. @eshiota can you clarify here? Write a basic CONTRIBUTING.md
There was a problem hiding this comment.
@sandrina-p I've highlighted this on our internal channel, but the summary is:
npm(which is what our lambda uses) runs thebuildtask when installing from GHyarnDOES NOT run thebuildtask when installing from GH, hence needing thedist- I don't feel we're stable enough to publish this package on the npm registry, which would consistently build the package for distribution
So I took the executive decision to push the dist diretory for now 😄
I also couldn't find the time to write a contribution/readme doc as my capacity for following up on this is unfortunately very thin right now.
There was a problem hiding this comment.
You did well, default to action ⚡ Thanks Shiota! Then, Gabriel, let's move on with the /dist :)
Could I ask you, Gabriel, to write the CONTRIBUTING based on your learnings. Even if incomplete, it's better than nothing :D
There was a problem hiding this comment.
let me find sometime tomorrow and I'll do it
export
ModifyConfig,ValidationResultandFormErrors