Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,23 +67,16 @@ opencode
Example output:

```
===============================================
BITCOINUI REVIEW: SendFeeView.swift
===============================================

MEDIUM (1 issue)
------------------
[UX] Line 88: Fee picker lacks a high-fee warning
Fix: Add a warning when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

LOW (1 issue)
------------------
[A11Y] Line 42: Icon-only close button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

===============================================
SUMMARY: 0 high, 1 medium, 1 low
===============================================
BITCOINUI

SendFeeView.swift
Findings: 0 high, 2 medium, 0 low

Medium
1) [UX L88] Fee picker lacks a high-fee warning
Fix: Add a warning when fee >= 50% of amount.
Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/
2) [A11Y L42] Icon-only close button has no label
Fix: Add accessibilityLabel("Close")
Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility
```
50 changes: 22 additions & 28 deletions commands/bitcoinui.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,42 +30,36 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W

## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including LOW).
Start directly with the `BITCOINUI` block; do not add any preamble text before it.
Omit any severity section with 0 findings (including Low).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

LOW (X issues)
------------------
...

===============================================
SUMMARY: X high, X medium, X low
===============================================
BITCOINUI

[file-or-folder]
Findings: X high, X medium, X low

High
1) [UX L42] Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

Medium
1) [A11Y L18] Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

Low
1) ...
```

## Guidance

1. Read the file(s) first before making assessments.
2. Be specific with line numbers and code snippets.
3. Provide fixes, not just problems.
4. Include a direct URL in each Reference line.
5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
4. Include a direct URL in each Ref line.
5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Ref line.
6. Suggest BitcoinUI components when they fit the pattern.
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
7. Low is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless asked; offer to fix if appropriate.
50 changes: 22 additions & 28 deletions site/bitcoinui.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,42 +30,36 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W

## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including LOW).
Start directly with the `BITCOINUI` block; do not add any preamble text before it.
Omit any severity section with 0 findings (including Low).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

LOW (X issues)
------------------
...

===============================================
SUMMARY: X high, X medium, X low
===============================================
BITCOINUI

[file-or-folder]
Findings: X high, X medium, X low

High
1) [UX L42] Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

Medium
1) [A11Y L18] Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

Low
1) ...
```

## Guidance

1. Read the file(s) first before making assessments.
2. Be specific with line numbers and code snippets.
3. Provide fixes, not just problems.
4. Include a direct URL in each Reference line.
5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
4. Include a direct URL in each Ref line.
5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Ref line.
6. Suggest BitcoinUI components when they fit the pattern.
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
7. Low is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless asked; offer to fix if appropriate.
28 changes: 17 additions & 11 deletions site/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
href="https://fonts.googleapis.com/css2?family=DM+Mono:wght@300;400;500&display=swap"
rel="stylesheet"
>
<link rel="stylesheet" href="style.css?v=6">
<link rel="stylesheet" href="style.css?v=7">
</head>
<body>
<main class="page">
<div class="panel">
<div class="panel-body">
<h1>Bitcoin UI</h1>
<p class="note">AI DESIGN REVIEW &amp; LIBRARY FOR BITCOIN IOS APPS</p>
<p class="note">DESIGN REVIEW &amp; LIBRARY FOR BITCOIN IOS APPS</p>
<hr class="divider">

<div class="section-group">
Expand Down Expand Up @@ -61,15 +61,21 @@ <h2><a href="https://opencode.ai/docs/commands/">OpenCode</a></h2>
</section>

<section class="block" id="flow">
<p class="note"><em>INSTALL -&gt; RUN BITCOINUI -&gt; GET A DESIGN REVIEW</em></p>
<pre class="output-block"><code>BITCOINUI REVIEW: SendFeeView.swift
===================================
MEDIUM (1 issue)
---------------
[UX] Line 88: Fee picker lacks a high-fee warning
Fix: Add a warning when fee &gt;= 50% of amount.
Reference: Bitcoin Design Guide - Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/
SUMMARY: 0 high, 1 medium, 0 low</code></pre>
<p class="note"><em>install -&gt; run bitcoinui -&gt; get a design review</em></p>
<pre class="output-block"><code>BITCOINUI

SendFeeView.swift
Findings: 0 high, 2 medium, 0 low

Medium

1) [UX L88] Fee picker lacks a high-fee warning
Fix: Add a warning when fee &gt;= 50% of amount.
Ref: Bitcoin Design Guide - Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/
2) [A11Y L142] Icon-only button has no label
Fix: Add an accessibilityLabel("Close") and include visible text.
Ref: iOS HIG - Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility</code></pre>

</section>
</div>

Expand Down
52 changes: 23 additions & 29 deletions site/skills/bitcoinui/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,42 +19,36 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG

1. Read the target file(s) before commenting.
2. Apply the rubric in `references/bitcoinui-rubric.md`.
3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Reference line.
4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Ref line.
4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Ref line.
5. Suggest BitcoinUI components when they would reduce errors or improve consistency.
6. Omit any severity section with 0 issues (including LOW).
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
6. Omit any severity section with 0 findings (including Low).
7. Low is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless the user asks; offer to fix if appropriate.

## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including LOW).
Start directly with the `BITCOINUI` block; do not add any preamble text before it.
Omit any severity section with 0 findings (including Low).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

LOW (X issues)
------------------
...

===============================================
SUMMARY: X high, X medium, X low
===============================================
BITCOINUI

[file-or-folder]
Findings: X high, X medium, X low

High
1) [UX L42] Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

Medium
1) [A11Y L18] Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

Low
1) ...
```

## References
Expand Down
2 changes: 1 addition & 1 deletion site/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ h2 a {
}

h2 a:hover {
color: var(--orange);
color: var(--green);
}

.section-title {
Expand Down
52 changes: 23 additions & 29 deletions skills/bitcoinui/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,42 +19,36 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG

1. Read the target file(s) before commenting.
2. Apply the rubric in `references/bitcoinui-rubric.md`.
3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Reference line.
4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line.
3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Ref line.
4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Ref line.
5. Suggest BitcoinUI components when they would reduce errors or improve consistency.
6. Omit any severity section with 0 issues (including LOW).
7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
6. Omit any severity section with 0 findings (including Low).
7. Low is for optional polish/consistency notes; skip it if there are no meaningful suggestions.
8. Do not modify code unless the user asks; offer to fix if appropriate.

## Output Format

Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it.
Omit any severity section with 0 issues (including LOW).
Start directly with the `BITCOINUI` block; do not add any preamble text before it.
Omit any severity section with 0 findings (including Low).

```
===============================================
BITCOINUI REVIEW: [filename]
===============================================

HIGH (X issues)
------------------
[UX] Line 42: Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

MEDIUM (X issues)
------------------
[A11Y] Line 18: Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

LOW (X issues)
------------------
...

===============================================
SUMMARY: X high, X medium, X low
===============================================
BITCOINUI

[file-or-folder]
Findings: X high, X medium, X low

High
1) [UX L42] Missing warning for fee > amount
Fix: Add a warning state when fee >= 50% of amount.
Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/

Medium
1) [A11Y L18] Icon-only button has no label
Fix: Add accessibilityLabel("Close")
Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility

Low
1) ...
```

## References
Expand Down