Add protobuf edition 2023 support #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
FWIW, looking at this now, the tests are probably overkill and I could easily remove them. |
Contributor
|
thank you! looks good to me, minus the committed binary, could you remove it? let's keep the test |
Author
|
@birdayz Done! |
Contributor
|
You will need to rewrite the history to eliminate the binary from git completely, otherwise it will be added with one of the "past" commits. |
statico
force-pushed
the
proto-edition-2023
branch
from
b2f9283 to
71b7350
Compare
Author
|
@birdayz Done as well! |
- Add FEATURE_SUPPORTS_EDITIONS flag to protoc plugin for edition compatibility - Create new edition_2023_test.proto with edition = "2023" syntax - Add edition_2023_test.go to verify field presence semantics work correctly - Generate edition 2023 compatible MCP handlers with pointer-based string fields - Maintain backward compatibility with existing proto2/proto3 files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
statico
force-pushed
the
proto-edition-2023
branch
from
71b7350 to
9f01bcb
Compare
birdayz
approved these changes
Aug 20, 2025
Contributor
|
last thing remaining: to correctly generate golden files. :) that will fix the ci error i believe. |
Author
|
OK! Sorry for the back and forth. I ran that and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! We'd like to use this project, but we're using edition 2023 protobufs and this project didn't seem to be compatible. I asked Claude Code to add compatibility.
🤖 Generated with Claude Code