Skip to content

refactor: generalize URL override to generic extra properties #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birdayz merged 2 commits into from
Aug 7, 2025
Merged

refactor: generalize URL override to generic extra properties #19

birdayz merged 2 commits into from
Aug 7, 2025

Conversation

@birdayz
Copy link
Contributor

@birdayz birdayz commented Aug 7, 2025 •
edited
Loading

Adds support for extending MCP tool schemas with arbitrary properties beyond the base protobuf definition.

New capabilities:

  • Add custom fields to tool schemas (name, description, required flag)
  • Extract values from MCP arguments and inject into request context
  • Support any context key type for value retrieval
  • Multiple extra properties per tool

Usage:

runtime.WithExtraProperties(
    runtime.ExtraProperty{
        Name: "api_url", 
        Description: "API endpoint", 
        Required: true,
        ContextKey: MyContextKey{},
    },
)

Enables dynamic configuration and schema flexibility for MCP tools.

@birdayz birdayz force-pushed the jb/middleware branch 2 times, most recently from b6dd750 to c5cb11b Compare August 7, 2025 13:42
@birdayz birdayz changed the title add host override key add url override option Aug 7, 2025
@birdayz
add base url override option
b5a33f0 
allows dynamic discovery of base url, allowing the LLM to input an
additional field for the url.
@birdayz birdayz force-pushed the jb/middleware branch 3 times, most recently from fb80c79 to 860e7d5 Compare August 7, 2025 15:51
@birdayz birdayz changed the title add url override option refactor: generalize URL override to generic extra properties Aug 7, 2025
@birdayz birdayz marked this pull request as ready for review August 7, 2025 17:30
@birdayz
refactor: generalize URL override to generic extra properties
e8bf844 
- Replace WithBaseURLProperty with WithExtraProperties supporting arbitrary fields
- Add configurable field name, description, required flag, and context key
- Remove URLOverrideKey in favor of user-provided context keys
- Maintain backward compatibility for URL parsing in user code
@birdayz birdayz merged commit 10b1375 into main Aug 7, 2025
4 checks passed
@birdayz birdayz deleted the jb/middleware branch August 7, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rockwotj rockwotj rockwotj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birdayz @rockwotj