ci: remove on push triggers and add concurrency#2170
Merged
Conversation
c-julin
force-pushed
the
jc/ci-tests-deduping
branch
from
a233360 to
f6d7f4d
Compare
c-julin
requested review from
a team,
graham-rp,
jvorcak,
malinskibeniamin,
r-vasquez,
sago2k8,
weeco and
yougotashovel
and removed request for
a team and
yougotashovel
malinskibeniamin
approved these changes
Jan 23, 2026
weeco
reviewed
Jan 23, 2026
|
|
||
| dispatch: | ||
| needs: [backend-verify, frontend-verify] | ||
| if: always() && !failure() && !cancelled() |
Contributor
There was a problem hiding this comment.
Why do we need this always() here? I probably don't understand the condition here
Contributor
Author
There was a problem hiding this comment.
its hangover from my previous test, if frontend was skipped it didn't trigger dispatch but now we run frontend and backend on both changes so can be safely removed
weeco
approved these changes
Jan 23, 2026
Contributor
|
LGTM, let's squash the commits before merging <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed push triggers directly on backend verify and frontend verify
Backend ci improved from ~9min to ~4min 🚤
created a new job to handle edge case for forked repos