Skip to content

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Jan 29, 2026

@uglide
Copy link
Contributor Author

uglide commented Jan 29, 2026

augment review

@augmentcode
Copy link

augmentcode bot commented Jan 29, 2026

🤖 Augment PR Summary

Summary: Adds TimeSeries support for NaN-aware aggregations introduced in RedisTimeSeries PR #1853.

API: Extends TsAggregation with CountNan and CountAll and updates shipped API surface.

Command building: Adds literal mappings (countnan, countall) in AggregationExtensions for request/response conversion.

Tests: Adds sync/async TS.RANGE coverage asserting COUNTNAN returns 2 and COUNTALL returns 5 for mixed data.

Compatibility: Tests are gated on Redis server version to avoid running on unsupported environments.

Notes: Ensure the minimum Redis version used in gates matches the feature’s actual availability.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@mgravell
Copy link
Collaborator

API change looks good; CI says

Key has MOVED to Endpoint 127.0.0.1:16379 and hashslot 1691 but CommandFlags.NoRedirect was specified - redirect not followed for TS.RANGE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants