Add support for self schedule preferred models#793
Add support for self schedule preferred models#793openshift-merge-bot[bot] merged 3 commits intoredhat-performance:mainfrom
Conversation
mcornea
force-pushed
the
self_sched_script
branch
3 times, most recently
from
ca75009 to
dfb7027
Compare
| WIPE_VALUE="false"; \ | ||
| else \ | ||
| WIPE_VALUE="true"; \ | ||
| fi; \ |
There was a problem hiding this comment.
If I am understanding this correctly, we have to pass a WIPE_VALUE to the make command in order to override hardware wiping for the workshop?
There was a problem hiding this comment.
Yeah, it's an option in the make prompt and it defaults to false to avoid the wipe for a quick release of the nodes.
There was a problem hiding this comment.
Ah, I see what happened while testing, I actually pulled the PR before that prompt was added. Maybe post workshop we should default wipe to true because the workshop is only leveraging pre-wiped hardware and afterwards folks will need to remember to wipe there hardware for the best possible result.
There was a problem hiding this comment.
Yeah, I'm still testing with wipe set to false as I'm seeing some issue with the generated inventory.
There was a problem hiding this comment.
I increased the retries to wait for the inventory to be ready: https://github.com/redhat-performance/jetlag/pull/793/changes#diff-7acd08e373d2f171069baaaf232424cc24bd9371f81d30fa062f461137206736R47
but it makes it more difficult to test before the workshop since the machines allocated with wipe false are not reachable.
Signed-off-by: Marius Cornea <mcornea@redhat.com>
mcornea
force-pushed
the
self_sched_script
branch
from
dfb7027 to
9ad2c84
Compare
akrzos
left a comment
akrzos
left a comment
There was a problem hiding this comment.
Ran the same scenario, by reusing the same hardware after releasing a cloud. Works great!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrzos The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d604286
into
redhat-performance:main
2 participants
No description provided.