Formatting support on web#1228
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Apr 2, 2026
Merged
Conversation
We switched the formatter implementation of yaml-language-server to be based on eemeli/yaml instead of prettier, since it can provide all the same functionality, and avoiding the extra dependency on prettier reduces the total size of the language server. Using prettier to provide formatting support was also a blocker for getting the formatting to work in the web version of the extension, since prettier doesn't work well with bundlers. This PR removes the shim that changed formatting on web to a NO-OP, since we should now be able to format properly on web. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
we-use-yaml-parser-as-formatter-instead-of-prettier
branch
from
8c3f57d to
73dfea2
Compare
datho7561
changed the title
datho7561
deleted the
we-use-yaml-parser-as-formatter-instead-of-prettier
branch
|
@datho7561 delighted to see this and feature parity in web - working great with the pre-release in the GitLab IDE! Looking forward to the next release 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We switched the formatter implementation of yaml-language-server to be based on eemeli/yaml instead of prettier,
since it can provide all the same functionality, and avoiding the extra dependency on prettier reduces the total size of the language server.
Using prettier to provide formatting support was also a blocker for getting the formatting to work in the web version of the extension, since prettier doesn't work well with bundlers.
This PR removes the shim that changed formatting on web to a NO-OP, since we should now be able to format properly on web.
What issues does this PR fix or reference?
N/A
Is it tested? How?