Merged
Conversation
datho7561
force-pushed
the
consolidate-tests
branch
5 times, most recently
from
89131ed to
eeeedd3
Compare
datho7561
force-pushed
the
consolidate-tests
branch
from
eeeedd3 to
f25ba47
Compare
- Use the vscode-test command line instead of a separate script in order to run the tests. - Add proper teardown to some test suites that didn't have it Switching over to the vscode-test cli changed the order in which the tests are executed. Since some tests didn't have proper teardown, the following tests in the suite started failing. By adding the proper teardown (and in one case changing the expected result) I got them passing again. Signed-off-by: David Thompson <davthomp@redhat.com> Reduce expected number of calls to get tests passing It used to be 2 because a document from a previous test was left open, which triggered the update twice (once during the direct invocation, and once during the faked document changed notification). Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
consolidate-tests
branch
from
f25ba47 to
0169408
Compare
Contributor
Author
|
Might as well get this merged in, it keeps getting stale so the sooner I make the change the less work it'll be later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switching over to the
vscode-testcli changed the order in which the tests are executed. Since some tests didn't have proper teardown, the following tests in the suite started failing. By adding the proper teardown (and in one case changing the expected result) I got them passing again.What issues does this PR fix or reference?
N/A
Is it tested? How?
CI