Skip to content

Conversation

@imliam
Copy link
Contributor

@imliam imliam commented Aug 18, 2025

I believe most PHP webapp monorepos are paired with a node_modules directory, so having this included in the check-conflicts command can significantly slow it down. As there's no way to pass through directories to exclude as options, I feel it's sensible to include as a default behaviour.

Here's the results on a pretty average app with/without this change:

With node_modules:

[OK] No conflicts found in 25686 files
7.5s total time taken

Without node_modules:

[OK] No conflicts found in 8818 files
1.4s total time taken

@samsonasik
Copy link
Member

Looks good, thank you @imliam

@samsonasik samsonasik merged commit f390aae into rectorphp:main Aug 19, 2025
8 checks passed
@TomasVotruba
Copy link
Member

Good point 👍 thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants