Skip to content

Print error message if dry-run option is used. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Aug 4, 2025
Merged

Print error message if dry-run option is used. #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/Command/FinalizeClassesCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected function configure(): void
'dry-run',
null,
InputOption::VALUE_NONE,
'Do no change anything, only list classes about to be finalized'
'Do no change anything, only list classes about to be finalized. If there are classes to finalize, it will exit with code 1. Useful for CI.'
);

$this->addOption('no-progress', null, InputOption::VALUE_NONE, 'Do not show progress bar, only results');
Expand Down Expand Up @@ -154,17 +154,26 @@ protected function execute(InputInterface $input, OutputInterface $output): int

$this->symfonyStyle->listing($finalizedFilePaths);

$this->symfonyStyle->success(sprintf(
'%d classes %s finalized',
count($finalizedFilePaths),
$isDryRun ? 'would be' : 'were'
));
$countFinalizedClasses = count($finalizedFilePaths);
$pluralClassText = $countFinalizedClasses === 1 ? 'class' : 'classes';

// to make it fail in CI
if ($isDryRun) {
$this->symfonyStyle->error(sprintf(
'%d %s can be finalized',
$countFinalizedClasses,
$pluralClassText,
));

return self::FAILURE;
}

return Command::SUCCESS;
$this->symfonyStyle->success(sprintf(
'%d %s finalized',
$countFinalizedClasses,
$pluralClassText,
));

return self::SUCCESS;
}
}