Move the type constraint on the function, not the body #2906
+29
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OCaml 4.14, ppxlib converts let f x = (x : int) to
Pexp_functionwith the type constraint attached to the function itself(Some (Pconstraint int))rather than as aPexp_constraintwrapping the body.The
curriedPatternsAndReturnValmethod returned the wholePexp_functionas the "return value" when a constraint was present, causing infinite recursion when the printer tried to process it again.The fix was to extract the body expression and wrap it in
Pexp_constraint/Pexp_coercewhen the function has a constraint, so the printer can process it without recursion.