Skip to content

Support melange.5.1.0-53#887

Merged
davesnx merged 7 commits intomainfrom
melange-5-support
Jun 4, 2025
Merged

Support melange.5.1.0-53#887
davesnx merged 7 commits intomainfrom
melange-5-support

Conversation

@davesnx
Copy link
Member

@davesnx davesnx commented Apr 3, 2025 •
edited
Loading

  • Installs melange.5.1.0
  • Removes mel.send.pipe from reason-react and their testing library
  • Removes embeded FormData from React and uses Js.FormData

@anmonteiro
Copy link
Member

anmonteiro commented Apr 6, 2025

I updated the tests here, is there anything missing before this can be merged?

@davesnx davesnx marked this pull request as ready for review April 9, 2025 13:23
davesnx
davesnx commented Apr 9, 2025
View reviewed changes
test/melange-testing-library/react/ReactTestingLibrary.re Outdated

module FireEvent = FireEvent;
module FireEvent = {
include FireEvent;
Copy link
Member Author

@davesnx davesnx Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change on purpose @anmonteiro ?

@davesnx
Copy link
Member Author

davesnx commented Apr 10, 2025

I want to make a release without ppxlib 0.36.0 (that would come with melange 5.1, if I'm not mistaken, per https://github.com/melange-re/melange/blob/main/melange.opam#L17) before merging this

davesnx added 2 commits June 4, 2025 12:35
@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into melange…
bebf0c8 
…-5-support

* 'main' of github.com:/reasonml/reason-react:
  feat(react-dom): add experimental module (#849)
  add color to domProps (#871)
  Remove most React.Uncurried from tests (but keep 1) (#890)
  fix melange dep
  Revert support for "custom children" in uppercase components (#891)
  ci: update nix action (#888)
@davesnx
Remove include on RTL
d63f762
@davesnx davesnx force-pushed the melange-5-support branch from 745082b to d63f762 Compare June 4, 2025 10:37
@davesnx davesnx merged commit 654fa3d into main Jun 4, 2025
3 checks passed
davesnx added a commit that referenced this pull request Jun 4, 2025
@davesnx
Merge branch 'main' of github.com:/reasonml/reason-react into prepare…
12522f9 
…-for-release

* 'main' of github.com:/reasonml/reason-react:
  Support melange.5.1.0-53 (#887)
  feat(react-dom): add experimental module (#849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davesnx @anmonteiro