Skip to content

Revert https://github.com/reasonml/reason-react/pull/875 #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davesnx wants to merge 2 commits into from
Closed

Revert https://github.com/reasonml/reason-react/pull/875 #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26c48a
update tests with melange 3 and ocaml 5.2
davesnx Feb 24, 2025
47a21b9
update setup-ocaml to v3 (#878)
anmonteiro Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/opam.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
key: opam-${{ matrix.os }}-${{ matrix.ocaml-compiler }}-${{ hashFiles('**.opam') }}

- name: Use OCaml ${{ matrix.ocaml-compiler }}
uses: ocaml/setup-ocaml@v2
uses: ocaml/setup-ocaml@v3
with:
ocaml-compiler: ${{ matrix.ocaml-compiler }}
dune-cache: true
Expand Down
96 changes: 12 additions & 84 deletions ppx/test/hover.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,59 +49,23 @@ Let's test hovering over parts of the component
},
"end": {
"line": 3,
"col": 33
},
"type": "React.element",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
},
"end": {
"line": 4,
"col": 15
"col": 29
},
"type": "React.element array",
"type": "string -> React.element",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
"line": 3,
"col": 17
},
"end": {
"line": 4,
"col": 15
"line": 3,
"col": 33
},
"type": "React.element",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
},
"end": {
"line": 4,
"col": 15
},
"type": "React.element option",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
},
"end": {
"line": 4,
"col": 15
},
"type": "ReactDOM.domProps",
"tail": "no"
},
{
"start": {
"line": 2,
Expand Down Expand Up @@ -160,63 +124,27 @@ The `foo` variable inside the component body
{
"start": {
"line": 3,
"col": 17
"col": 30
},
"end": {
"line": 3,
"col": 33
},
"type": "React.element",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
},
"end": {
"line": 4,
"col": 15
},
"type": "React.element array",
"type": "string",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
"line": 3,
"col": 17
},
"end": {
"line": 4,
"col": 15
"line": 3,
"col": 33
},
"type": "React.element",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
},
"end": {
"line": 4,
"col": 15
},
"type": "React.element option",
"tail": "no"
},
{
"start": {
"line": 2,
"col": 2
},
"end": {
"line": 4,
"col": 15
},
"type": "ReactDOM.domProps",
"tail": "no"
},
{
"start": {
"line": 2,
Expand Down
Loading
Loading